New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor inconvenience in tutorials #1885
Comments
A simple solution would be to just disable the line numbers. They're probably not needed. |
Weirdly enough, when I build the docs locally, it's a bit different. I can't highlight the line numbers and copying using the button doesn't include the line numbers. So maybe this can be fixed. |
Might be better to disable the line numbers to be consistent with other tutorials |
@cadmus-to, thanks for pointing this out. I agree it would be better to make this consistent by disabling line numbers. I'm going to mark this as help wanted. If you want to make a PR, feel free to @ me as a reviewer. |
This is actually a bug in the Read-the-Docs theme; see readthedocs/sphinx_rtd_theme#1123 (where it has been fixed and merged, but not released yet). Possible solutions:
The line numbers are an easy way to refer back to code, but I agree that this is inconsistent with the rest of our tutorials. So I'd be fine with just removing that, though a bunch of the text will need to be rewritten to have code inline rather than "see Line 8" or whatever. |
Yes, I was using Sphinx 3. I did see that issue (and other related ones) and upgraded to Sphinx 4 and then tried a pre-release version of the RTD theme (1.0.0rc1), but it didn't entirely fix the issue. I couldn't select the line numbers (as expected), but copying using the button incorrectly copied the line numbers: executablebooks/sphinx-copybutton#85 |
Hi is anyone working on this? If not so, I would like to get started on this |
I'm fairly new to git culture, but I don't think anyone is because no PRs have referenced this issue |
Sure Thanks! |
It turns out that this was simpler than I thought; #1906 should fix it. |
Just want to flag that the action tutorial pages
has code blocks including line numbers. When we use the copy feature, those are copied too.
The text was updated successfully, but these errors were encountered: