-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable taking photo with "volume down" button #9
Comments
I would say this should be implemented into the react-native-camera library itself. |
Another option would be to create a new library just for this purpose. https://github.com/FakeYou/react-native-volume I've already done something similar, it shouldn't be too hard. |
I like doing PR to react-native-camera, but we don't use RNC. We could do PR to expo, however. Doing new lib for it, seems like an overkill. What do you think? |
Sorry I meant expo. Actually I think it's the other way around. Creating a library is fairly easy and you cant test what is necessary in a standalone situation, then it can more easily be merged into an existing library. |
Obvious stuff
In almost every app that takes photos, it is possible to take photo via pressing the volume down button. It's a minor UX feature, but industry standard.
While on Camera screen, pressing the button should take photo.
Experiment
Let's try to experiment a bit, if it doesn't work UX-wise we will change it later.
Shooting via "volume down" button, does not automatically open the "preview" screen. Instead it behaves like you're taking another page.
The text was updated successfully, but these errors were encountered: