Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable taking photo with "volume down" button #9

Open
zepod opened this issue Apr 11, 2019 · 4 comments
Open

Enable taking photo with "volume down" button #9

zepod opened this issue Apr 11, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@zepod
Copy link
Contributor

zepod commented Apr 11, 2019

Obvious stuff
In almost every app that takes photos, it is possible to take photo via pressing the volume down button. It's a minor UX feature, but industry standard.

While on Camera screen, pressing the button should take photo.

Experiment
Let's try to experiment a bit, if it doesn't work UX-wise we will change it later.
Shooting via "volume down" button, does not automatically open the "preview" screen. Instead it behaves like you're taking another page.

@EskelCz
Copy link
Contributor

EskelCz commented Apr 12, 2019

I would say this should be implemented into the react-native-camera library itself.
There is an issue for it already, just no code yet.
react-native-camera/react-native-camera#764
I'll look into it.

@EskelCz
Copy link
Contributor

EskelCz commented Apr 12, 2019

Another option would be to create a new library just for this purpose.
I've found a lot of code for both platforms separately, it's just a matter of combining them into a new one which covers both with the same api.

https://github.com/FakeYou/react-native-volume
https://github.com/ifours/react-native-volume-slider
https://github.com/gevorg94/react-native-volume-handler
https://github.com/thebylito/react-native-button-handler
https://github.com/rnavarych/react-native-volume-button-handler

I've already done something similar, it shouldn't be too hard.

@zepod
Copy link
Contributor Author

zepod commented Apr 16, 2019

I like doing PR to react-native-camera, but we don't use RNC. We could do PR to expo, however. Doing new lib for it, seems like an overkill. What do you think?

@EskelCz
Copy link
Contributor

EskelCz commented Apr 16, 2019

Sorry I meant expo. Actually I think it's the other way around. Creating a library is fairly easy and you cant test what is necessary in a standalone situation, then it can more easily be merged into an existing library.
Still, it would take me about a day for each platform.

@EskelCz EskelCz added enhancement New feature or request and removed Low priority labels May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants