Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status of the Liquity protocol to the frontend #3971

Open
yabirgb opened this issue Jan 19, 2022 · 1 comment · May be fixed by #6578
Open

Add status of the Liquity protocol to the frontend #3971

yabirgb opened this issue Jan 19, 2022 · 1 comment · May be fixed by #6578
Labels
backend easy Easy issue. But maybe not good first. Fast if you are a bit familiar. frontend good first issue Good for newcomers liquity
Milestone
1.36.0

Comments

@yabirgb
Copy link
Member

yabirgb commented Jan 19, 2022 •
edited

The collateral ratio of the Liquity protocol is important to detect when liquidations in recovery mode can happen. More at https://docs.liquity.org/faq/recovery-mode. It would be nice to have it in rotki since now you have to visit other frontends to know if your position is safe or not

For this to be added the backend needs to call the contracts and inspect the status of the protocol and the frontend needs to properly display this information.

We need to call https://etherscan.io/address/0xA39739EF8b0231DbFA0DcdA07d7e29faAbCf4bb2#readContract for
image

and do

(systemColl * eth price) / (systemDebt * lusd price)
@LefterisJP LefterisJP added this to the 1.30.0 milestone Jul 28, 2023
@LefterisJP LefterisJP added good first issue Good for newcomers easy Easy issue. But maybe not good first. Fast if you are a bit familiar. labels Jul 28, 2023
@LefterisJP LefterisJP modified the milestones: 1.30.0, 1.31.0 Aug 17, 2023
@3scava1i3r
Copy link

taking this up, @yabirgb

@3scava1i3r 3scava1i3r linked a pull request Sep 7, 2023 that will close this issue
Open
1 task
@LefterisJP LefterisJP modified the milestones: 1.31.0, 1.32.0 Nov 25, 2023
@LefterisJP LefterisJP modified the milestones: 1.32.0, 1.33.0 Feb 16, 2024
@LefterisJP LefterisJP modified the milestones: 1.33.0, 1.36.0 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend easy Easy issue. But maybe not good first. Fast if you are a bit familiar. frontend good first issue Good for newcomers liquity
Projects
None yet
Milestone
1.36.0
Development

Successfully merging a pull request may close this issue.

feat:add the collateral ratio of the Liquity protocol in troves.py 3scava1i3r/rotki
3 participants
@LefterisJP @yabirgb @3scava1i3r