Update BPF lexer #2004
Merged
Update BPF lexer #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed type keywords such as s16 have always been supported by BPF but recently became more frequent. They were missing in the original lexer so this commit adds them, with an example. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
The lexer already supports the following syntax for call instructions:
call bpf_skb_load_bytes#1234
but a simpler syntax without the number at the end is now also possible.
This commit adds support for it, with an example.
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
The original lexer was missing support for the little-endian
byte-swapping instructions le{16,32,64}. This commit adds them, together
with the new bswap{16,32,64} instructions. The later are unconditional
byte-swapping instructions, meaning they don't depend on the
architecture.
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
Hexadecimal literals can also have a sign in BPF. This commit fixes this error in the lexer and adds a corresponding example. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
The offset of BPF jump instructions is now sometimes displayed in hexadecimal format. This commit adds support for that, together with an example. It also adds an example to cover the syntax where the jump has both an offset literal and an offset label (ex. "+1 <LBB0_2>"). Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
Jump instructions with a 32-bit offset are displayed as "gotol" instead of "goto". Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
|
Thank you for the contribution @pchaigno ❤️ The changes LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the BPF lexer to highlight several constructs and keywords that were either missed in the initial lexer or were recently added to BPF:
s8,s16,s32, ands64type keywords.call helper_namesyntax.le16,le32,le64and the newbswap16,bswap32,bswap64keywords.-0xa5syntax for negative hexadecimal.goto 0x1234 <label>syntax for jumps.gotolkeyword for long jumps.All come with visual examples.