Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fig 1.8 not referenced in text #16

Open
gschivley opened this issue Nov 17, 2021 · 3 comments
Open

Fig 1.8 not referenced in text #16

gschivley opened this issue Nov 17, 2021 · 3 comments

Comments

@gschivley
Copy link

There is no reference to Figure 1.8 in the exercises at the end of Chapter 1. Maybe it is supposed to be associated with Exercise 1 (produce a figure with an exact pixel size)? If so, some reference to the figure in that section of the text would be helpful. And if it is supposed to be an example of setting exact figure pixel size, the code for Fig 1.8 could be more specific about defining what the figure pixel size is.

As a side note, the method of generating Fig 1.8 is interesting but perhaps unnecessarily complicated for this part of the book? Is it demonstrating something discussed in Chapter 1?

@rougier
Copy link
Owner

rougier commented Nov 22, 2021

Thanks, I think you're right on both comments (need to reference it in exercise 1, need the solution to be 512x512 pixels and needs to be much simpler). Would you like to propose a PR?

@gschivley
Copy link
Author

Back from Thanksgiving break, will see if I can do something this week.

@rougier
Copy link
Owner

rougier commented Dec 15, 2021

Gentle reminder before Christmas break. No problem if you can't do it, I will modify the relevant part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants