Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark framework by let them doing the same work. #7

Open
fakeshadow opened this issue Aug 6, 2021 · 1 comment
Open

Benchmark framework by let them doing the same work. #7

fakeshadow opened this issue Aug 6, 2021 · 1 comment

Comments

@fakeshadow
Copy link

There are some obvious problem with the bench.

  1. actix-web and warp return a String while others return a &'static str. This means they have additional allocation for generating payload while others don't.

  2. hyper being low level does not set content-type header. And I believe all other tests do set it to "plain/text" or "text/plain; charset=utf-8". So it should set one to be on par.

  3. warp by the test method mentioned in README.md does not generate meaningful response because it can not find the route you defined. This makes it return a 404 response that has no payload so it bypass the response body entirely. This is mentioned in issue Rocket v5 (async) bencmark #2.

@rousan
Copy link
Owner

rousan commented Aug 8, 2021

@fakeshadow, can you please send PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants