Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with with flexboxgrid2@>=7.0.0-alpha12 #145

Open
houkanshan opened this issue Feb 2, 2018 · 14 comments
Open

Not compatible with with flexboxgrid2@>=7.0.0-alpha12 #145

houkanshan opened this issue Feb 2, 2018 · 14 comments

Comments

@houkanshan
Copy link

Hi, recently I upgraded react-flexbox-grid, but found that all the padding of <Col> missing.

flexboxgrid2@7.0.0-alpha12 began to use [class^="col-"] selector instead of using class name explicitly. Which I believe will be dropped by css-loader's CSS Modules when we @import styles from 'flexboxgrid2/flexboxgrid2.css';

If we install react-flexbox-grid with yarn then everything will be fine because flexboxgrid2's version is locked to 7.00-alpha7 by yarn.lock. But if we install it with npm, then flexboxgrid2@7.1.0 will be selected according to ^7.0.0-alpha7 in package.json.

So currently can we just lock flexboxgrid2's version to 7.0.0-alpha7 in package.json?

Thank you!

@hilarykitz
Copy link

+1 for this issue. We lose all shared column styling and are only left with the column width class. Makes for a very sad looking grid.

@jacargentina
Copy link

My repo at https://github.com/jacargentina/flexboxgrid2 fixes this. @roylee0704 could u update to use my fork?

@imevro
Copy link

imevro commented Feb 27, 2018

@jacargentina if we will switch forks just for minor bugs, we will never use stable software.

@imevro
Copy link

imevro commented Feb 27, 2018

@houkanshan can you reproduce problem with css loader on codesandbox.io? Because it is absolutely valid css and if this bug is really with loader, we need file an issue to them.

@imevro
Copy link

imevro commented Feb 28, 2018

Fixed in 7.2.0

imevro added a commit to imevro/react-flexbox-grid that referenced this issue Feb 28, 2018
@jacargentina
Copy link

@evgenyrodionov Who is in charge for new versions here? Getting that new dependency 7.2.0 would be nice!!

@imevro
Copy link

imevro commented Mar 7, 2018

@jacargentina @roylee0704 I guess

@jacargentina
Copy link

@roylee0704 Please, publish a new version, having flexboxgrid2 updated to 7.2.0

@jacargentina
Copy link

@silvenon @heldr I've tried contacting @roylee0704 to its gmail, but not having response. Somebody is actively looking at the project? it is discontinued ?

@silvenon
Copy link
Collaborator

silvenon commented Apr 5, 2018

I merged the PR, but unfortunately I don't have permissions to publish the new version of react-flexbox-grid. 😢

@heldr
Copy link
Collaborator

heldr commented Apr 5, 2018

Me neither 😢

@jacargentina
Copy link

@silvenon @heldr any way to contact @roylee0704 ? Is he alive?

@silvenon
Copy link
Collaborator

silvenon commented Apr 5, 2018

I'm sure he's alive 😄 he just doesn't seem to have a strong online presence or has other things to do. I reached out to him and will let you know if he replies. (Déjà vu. #99)

@jacargentina
Copy link

@houkanshan and everybody following.
I've put this https://jacargentina.github.io/react-flexbox-grid/
It is full of updates! Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants