Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive height of Row #154

Open
Ryukote opened this issue Jun 14, 2018 · 0 comments
Open

Responsive height of Row #154

Ryukote opened this issue Jun 14, 2018 · 0 comments

Comments

@Ryukote
Copy link

Ryukote commented Jun 14, 2018

Hello,

On the screen of my Surface Pro 3 everything is as I want, but when I try to open page on my phone (Nokia Lumia 930...don't judge me, my Android phone is on warranty service), height of the elements seems like too small. Shouldn't responsive means that on smaller screens, elements should be bigger?

Here is what I have:

import React from 'react';
import {InputGroup, InputGroupAddon, Input, Button} from 'reactstrap';
import {Grid, Row, Col} from 'react-flexbox-grid';

class Login extends React.Component{
    render(){
        return(
                    <Grid>
                            {/*Row for username*/}
                            <Row xs="6">
                                <Col xs={3} sm={3}/>
                                    
                                <Col xs={6} sm={6}>
                                    <InputGroup id="loginGroup">
                                        <InputGroupAddon addonType="prepand">
                                            @
                                        </InputGroupAddon>

                                        <Input placeholder="username" />
                                    </InputGroup>
                                </Col>

                                <Col xs={3} sm={3}/>
                            </Row>

                            <br/>

                            {/*Row for password*/}
                            <Row>
                                <Col xs={3} sm={3}/>
                                    
                                <Col xs={6} sm={6}>
                                    <InputGroup id="loginGroup">
                                        <InputGroupAddon addonType="prepand">
                                            ....
                                        </InputGroupAddon>

                                        <Input placeholder="password" type="password" />
                                    </InputGroup>
                                </Col>

                                <Col xs={3} sm={3}/>
                            </Row>

                            <br/>

                            <Row className="text-center">
                                <Col xs={3} sm={3}/>
                                    
                                <Col xs={6} sm={6}>
                                        <Button color="primary">Login</Button>
                                </Col>

                                <Col xs={3} sm={3}/>
                            </Row>
                    </Grid>
        );
    }
}

export default Login;

Can I change height of the Row component trough some property, or do I need to write some magic in CSS? (Which I want to avoid)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant