Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoomable image breaks on Chrome #470

Closed
1 of 4 tasks
brew-matija opened this issue Mar 15, 2024 · 7 comments · Fixed by #561
Closed
1 of 4 tasks

Zoomable image breaks on Chrome #470

brew-matija opened this issue Mar 15, 2024 · 7 comments · Fixed by #561
Assignees
Labels

Comments

@brew-matija
Copy link

brew-matija commented Mar 15, 2024

Issue Type

  • Bug report
  • Feature request
  • Question / support request
  • Other

Description

This bug is apparent only in Chrome. Tested it in Firefox and Safari, those work as normal. When clicking a zoomable image, it sometimes works properly, and other times it doesn't show a magnifying glass cursor, just a regular pointer and if you click the image then it disappears and the other page interactions are broken. Escape key does nothing and the only way out is to refresh the page. On subsequent refreshes the component sometimes works properly and sometimes doesn't.
Tried both the Controlled and Uncontrolled versions, same thing.

Place detailed information here
Chrome Version 122.0.6261.129 (Official Build) (arm64)
MacOS Sonoma Version 14.0 (23A344)
Next 13.5.6

@rpearce
Copy link
Owner

rpearce commented Mar 15, 2024

@brew-matija Can you please provide a functioning sample of this breaking for me to work with? It works for me in Chrome. Thank you for providing browser, OS, and environment details.

@jiayihu
Copy link

jiayihu commented May 12, 2024

I've noticed the same issue and it can be reproduced with a lazy-loaded image, by clicking the image before the image has been loaded.

@rpearce
Copy link
Owner

rpearce commented May 12, 2024

Ah, that's interesting. Thanks for the context!

@rpearce rpearce self-assigned this May 12, 2024
@rpearce
Copy link
Owner

rpearce commented May 13, 2024

I've got a fix for this I'll try to get out in the next 6-10 hours

@rpearce
Copy link
Owner

rpearce commented May 13, 2024

@brew-matija @jiayihu This should be fixed in react-medium-image-zoom@5.2.1. If there are additional issues, you know where to find me! I added you both to the "All Contributors" list in the README; thank you for your bug reporting.

@rpearce
Copy link
Owner

rpearce commented May 13, 2024

Update: I found an accidental dependency on @storybook/test that shouldn't there and just released react-medium-image-zoom@5.2.2. It won't make a difference for this issue, but it is the latest, and it should reduce the dependencies size back down to zero.

@jiayihu
Copy link

jiayihu commented May 15, 2024

I finally tested the fix and I can confirm it's working correctly now, thanks for the quick fix ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants