Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf builddep --spec returns 'Unknown argument' #799

Open
bcl opened this issue Aug 3, 2023 · 1 comment · May be fixed by #810
Open

dnf builddep --spec returns 'Unknown argument' #799

bcl opened this issue Aug 3, 2023 · 1 comment · May be fixed by #810
Labels
Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Milestone
Fedora 41

Comments

@bcl
Copy link

bcl commented Aug 3, 2023

See https://github.com/osbuild/weldr-client/actions/runs/5752335719/job/15593094835?pr=114

I understand that the dnf5 builddep may be different, and from the --help output it only accepts .spec files so --spec is redundant, but it might make the transition from dnf4 easier if it accepted --spec without an error.
@dcantrell
Copy link

Yeah, this is reasonable and will make it easier for people bringing scripts and commands to dnf5 from legacy dnf. I've added --spec and --srpm as no-op arguments for the builddep command. It's true the behavior is different and dnf5 doesn't require the explicit argument anymore, but the no-op commands are fine.

dcantrell added a commit to dcantrell/dnf5 that referenced this issue Aug 9, 2023
@dcantrell
Add --spec and --srpm no-op arguments to the builddep plugin
4a8a9b3 
Under dnf4 the builddep command accepted the --spec or --srpm argument
(mutually exclusive) to tell dnf what the input to the command was.
With dnf5 the command is more intelligent and the arguments are not
required.  However, if you are bringing a script over from an existing
system and you have --spec or --srpm for the builddep dnf command, you
will get this error:

    Unknown argument "--spec" for command "builddep". Add "--help" for more information about the arguments.

This patch addes the --spec and --srpm arguments to the builddep
command, but they are ignored.  They exist for backwards
compatibility.

Fixes: rpm-software-management#799

Signed-off-by: David Cantrell <dcantrell@redhat.com>
@dcantrell dcantrell linked a pull request Aug 9, 2023 that will close this issue
Open
@jan-kolarik jan-kolarik added the Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take label Aug 15, 2023
@jan-kolarik jan-kolarik added this to the Fedora 41 milestone Jan 30, 2024
@kontura kontura mentioned this issue Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
DNF team
Status: Backlog
Milestone
Fedora 41
Development

Successfully merging a pull request may close this issue.

Add --spec and --srpm no-op arguments to the builddep plugin dcantrell/dnf5
3 participants
@dcantrell @bcl @jan-kolarik