Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

test: block_exchange::long_get_block is ignored #450

Open
koivunej opened this issue Jan 26, 2021 · 2 comments
Open

test: block_exchange::long_get_block is ignored #450

koivunej opened this issue Jan 26, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@koivunej
Copy link
Collaborator

koivunej commented Jan 26, 2021 •
edited

See original comment. Should at minimum understand why it no longer works.
@koivunej koivunej added the bug Something isn't working label Jan 26, 2021
@koivunej koivunej mentioned this issue Jan 26, 2021
Merged
@koivunej
Copy link
Collaborator Author

I was hoping for #454 to magically fix this but alas, no change.

bors bot added a commit that referenced this issue Jan 27, 2021
@bors @koivunej
Merge #453
cf37032 
453: Fix multinode test spans r=koivunej a=koivunej

This PR changes how the spans are set up from IpfsOptions and in UninitializedIpfs. While debugging the now ignored test (see #450) I found that the spans were configured wrong and thus none of the multiple nodes created by `spawn_nodes` could be differentiated.

This also renames the spans to more logical from the "$root" given at `IpfsOptions::span`:

`Span::current` => `$root:init`
`Span::current` => `$root:init:swarm`
`$root:swarm` => `$root:exec` (literally the executor libp2p spawns futures through)
`$root` => `$root:bg_task` => `$root:swarm` (background task)
`$root` => `$root:facade` (futures created through Ipfs::* methods)

Still very far from perfect, but perhaps a step into better direction.

Co-authored-by: Joonas Koivunen <joonas.koivunen@gmail.com>
@koivunej
Copy link
Collaborator Author

This might be simply that libp2p-kad no longer goes to work before a single peer has been add_peer'd to its routing table. I do believe this should have had a changelog entry...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@koivunej