Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Content discovery, timeouts, and retrying #451

Open
koivunej opened this issue Jan 26, 2021 · 1 comment
Open

Content discovery, timeouts, and retrying #451

koivunej opened this issue Jan 26, 2021 · 1 comment
Labels
bitswap bug Something isn't working dht

Comments

@koivunej
Copy link
Collaborator

We should retry if either the dht query finds no results or none of our existing peers have or give us the block.

I'll PR the test case soon enough.

Expected: we should retry the content discovery while trying the old and new peers. In the best case scenario we'd support the latest bitswap spec but we should also handle timeouts to wantlist items.

@koivunej
Copy link
Collaborator Author

koivunej commented Feb 5, 2021

(I've been a bit burdened with other work.) Perhaps the idea of timeouts is all wrong given the messaging (not rpc) based approach envisioned in bitswap spec. The #452 simple case can be fixed by having the peer2 (who will be put_block'd) fulfill the want to peer1 after peer2.put_block. Now, this will allow to keep a simple 1.0 implementation which doesn't really poll peers, but need to check if other implementations are treating this as a "remember wantlist while connected" setup which might imply a bit of trust.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bitswap bug Something isn't working dht
Projects
None yet
Development

No branches or pull requests

1 participant