Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypedArrays wrong? #64

Open
pmarques opened this issue May 4, 2016 · 3 comments
Open

TypedArrays wrong? #64

pmarques opened this issue May 4, 2016 · 3 comments

Comments

@pmarques
Copy link

pmarques commented May 4, 2016

I was looking around and in TypedArrays the example seems to not work properly for username.
In the username setter you have this._username[0] = v v is a string _username is a Uint8Array, I was wondering if there is a new feature to cast one into the other but I didn't find anything.
I understand if this is just for a example, I just want to know if there is something that I didn't catch.

@rse
Copy link
Owner

rse commented Jun 25, 2016

You are right, the example is wrong. I'll try to fix it soon.

@extempl
Copy link

extempl commented Sep 30, 2016

Btw, @rse you should either increase line-height in the code or remove extra highlight background (maybe make it semi-transparent), because in some parts comma looks like a dot: https://cl.ly/0y2c3k2w1x2R

@rse
Copy link
Owner

rse commented Oct 1, 2016

The line height issue is now fixed. The fixed TypedArray example still not (still coming).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants