-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Watching multiple builds #12
Comments
What version of estrella is this? (try You can also try enabling debug mode of estrella to get some more detailed output by adding |
Version is 1.2.8 (latest). Here's the debug output
Both of the meta files exist on disk. I found it's actually the cwd that is not taken into account when loading the meta file, that's why I get the read errors. By the way, in another expirement I've also seen the cwd not being accounted for in the run option. |
Can you try https://github.com/rsms/estrella/tree/1af2aff987261ec3a36b015820b64699bf0dac95/dist (or git master) ? |
That works, thanks! Run is still executed in the original directory though. Not sure if that is intended? In a scenario like this I'd sort of expect run to be scoped to cwd too: build({
platform: 'node',
cwd: 'packages/server',
entry: 'src/server.ts',
outfile: 'dist/server.js',
run: 'node dist/server.js'
}) |
I spoke too soon. While I can invoke the build with |
An example setup of what I'm trying to achieve below. Where you might run // build.js
require('./packages/a/build.js')
require('./packages/b/build.js')
// packages/a/build.js
const { build } = require('estrella')
build({
cwd: __dirname,
entry: 'src/a.ts',
outfile: 'dist/a.js',
bundle: true
})
// packages/b/build.js
const { build } = require('estrella')
build({
cwd: __dirname,
entry: 'src/b.ts',
outfile: 'dist/b.js',
bundle: true
}) |
I'd be happy to accept a PR along with an investigation report and a test. I'm not a native Windows developer (I just fire it up in a VM when I need to test things.) |
Some of the improvements have been published with v1.3.0 |
The only actionable problem that was left here was As far as Windows specific issues I did not run into any. I moved my setup to one where I didn't need the As mentioned in my previous PR, sadly the existence of the 'aux.ts' file makes further Windows development too much of a pain (can't checkout the repo or build) and even makes git installs via yarn/npm fail. So for the time being I went with a |
The docs say multiple builds in one file should be fine (under "Building multiple products at once"). While building works without issues, running
--watch
on such a build file currently streams a bunch of errors (whereas a single build watches fine):The text was updated successfully, but these errors were encountered: