Improve route spec generation for controller generators

[cupakromer]

If you use the Rails generator to create a controller with some actions, it will automatically add basic routes for it. This feature would need to do two things:

1. Automatically add passing specs for the generated routes
2. If no actions / routes were specified, include our default filler message

From #1155 (see discussion)

[glittershark]

I'm happy to take this on if nobody's working on it right now.

[cupakromer]

Sure thanks for the help @glittershark 💙

[b-lambert]

Looks like @glittershark gave up on this? I'd be happy to take it on!

[fables-tales]

@b-lambert go ahead! As far as I'm aware we've not seen any further action on this pull request :)

[siakaramalegos]

I'm not sure I quite understand what the request is - rspec already generates a controller test for any route specified in the generator. What's an example of an "improved" test?

For example, if you run rails g controller Delete test, it generates a controller spec file with the content:

require 'rails_helper'

RSpec.describe DeleteController, type: :controller do

  describe "GET #test" do
    it "returns http success" do
      get :test
      expect(response).to have_http_status(:success)
    end
  end

end

If the test route is removed from the generated command, this is what you get instead:

require 'rails_helper'

RSpec.describe DeleteController, type: :controller do

end

What do we want instead?

[fables-tales]

@siakaramalegos I believe the idea is to generate routing specs: https://www.relishapp.com/rspec/rspec-rails/v/2-4/docs/routing-specs

[siakaramalegos]

Oh interesting! I'll wait a bit to see if @b-lambert picks it up.

[glittershark]

I had actually done this (two years ago D:) but gave up when I couldn't manage to make the tests pass. Maybe I can see if I can dredge it up from a backup on whatever computer I had then

[b-lambert]

@glittershark see what you can dredge up!

[00dav00]

@cupakromer @b-lambert @glittershark If you guys don't I would like to work on this one :)

[b-lambert]

I'm no longer working on it so it's up to @glittershark

[00dav00]

@cupakromer This PR should cover the requested feature.

CC @b-lambert

[klyonrad]

Seems like this issue can be closed with #2134, right?