New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work out testing story for ActionCable #1606
Comments
I made this ruby client for action cable: https://github.com/NullVoxPopuli/action_cable_client |
Hi @NullVoxPopuli, thanks for the suggestion, but we're going to take RSpec in a slightly different direction to test with ActionCable 😄 |
Whats the official Rails line on this @samphippen ? |
Waiting for rails/rails#23211 to be merged before I start investigating. |
Hi, @samphippen! I've extracted rails/rails#23211 into a gem and added RSpec support too – https://github.com/palkan/action-cable-testing. |
Hey, folks! It's been a while... Since The gem already has RSpec support (built using the same structure as The main question for now is whether we should use the RSpec 4.x branch or target the 3.x version? |
TBH if you target 3.x it's going to be easy to cherry-pick it to 4.x, but it really depends on if we want to release this before 4.x, which is scheduled for release around rails-conf |
the 3.xx series will likely not get rails 6.0 support, so you should target 4.xx |
Ah if this is intended as an Rails 6.0 only feature then yes definitely just 4.x |
Yep, it's Rails 6+. Ok, thanks guys; we'll provide a PR for 4.x.x. |
We merged support for this, closing. |
We currently don't have one, so we should definitely work out what the story is.
The text was updated successfully, but these errors were encountered: