Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out testing story for ActionCable #1606

Closed
fables-tales opened this issue Apr 24, 2016 · 11 comments
Closed

Work out testing story for ActionCable #1606

fables-tales opened this issue Apr 24, 2016 · 11 comments
Labels

Comments

@fables-tales
Copy link
Member

We currently don't have one, so we should definitely work out what the story is.

@NullVoxPopuli
Copy link

I made this ruby client for action cable: https://github.com/NullVoxPopuli/action_cable_client
could it help with testing action cable?

@fables-tales
Copy link
Member Author

Hi @NullVoxPopuli, thanks for the suggestion, but we're going to take RSpec in a slightly different direction to test with ActionCable 😄

@JonRowe
Copy link
Member

JonRowe commented May 16, 2016

Whats the official Rails line on this @samphippen ?

@fables-tales
Copy link
Member Author

Waiting for rails/rails#23211 to be merged before I start investigating.

@palkan
Copy link
Contributor

palkan commented Oct 24, 2017

Hi, @samphippen!

I've extracted rails/rails#23211 into a gem and added RSpec support too – https://github.com/palkan/action-cable-testing.

@palkan
Copy link
Contributor

palkan commented Jan 21, 2019

@samphippen @benoittgt

Hey, folks! It's been a while...

Since action-cable-testing has been merged into Rails 6.0, we think it's time to take care of RSpec part)

The gem already has RSpec support (built using the same structure as rspec-rails), so it's gonna be pretty easy to merge it.

The main question for now is whether we should use the RSpec 4.x branch or target the 3.x version?

@JonRowe
Copy link
Member

JonRowe commented Jan 22, 2019

TBH if you target 3.x it's going to be easy to cherry-pick it to 4.x, but it really depends on if we want to release this before 4.x, which is scheduled for release around rails-conf

@fables-tales
Copy link
Member Author

the 3.xx series will likely not get rails 6.0 support, so you should target 4.xx

@JonRowe
Copy link
Member

JonRowe commented Jan 22, 2019

Ah if this is intended as an Rails 6.0 only feature then yes definitely just 4.x

@palkan
Copy link
Contributor

palkan commented Jan 22, 2019

if this is intended as an Rails 6.0 only feature

Yep, it's Rails 6+.

Ok, thanks guys; we'll provide a PR for 4.x.x.

@palkan palkan mentioned this issue Apr 26, 2019
5 tasks
@JonRowe
Copy link
Member

JonRowe commented Mar 12, 2020

We merged support for this, closing.

@JonRowe JonRowe closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants