represent_boolean_as_integer is deprecated

[ahorek]

see rails/rails@f59b081#diff-0a1a3158ff1c2956f5e096a250c11a66

[JonRowe]

Hm, I'm not sure I know what that file did, @samphippen ?

[fables-tales]

I’d be willing to accept this if it came with a test for rails 6 specifically that demonstrated the behaviour.

[eugeneius]

Rails 5.2 emits a deprecation warning if you don't set represent_boolean_as_integer; Rails 6 will emit a deprecation warning if you do set it. I think the only reason this file exists is to suppress the warning, and the actual behaviour toggled by the setting is irrelevant to RSpec Rails.

This change will fix the failures that are currently blocking the Rails master build on the 4-0-dev branch, so I don't think it needs a test: https://travis-ci.org/rspec/rspec-rails/jobs/499526847#L2084

[JonRowe]

@eugeneius it does, because it also affects older rails versions, at the very least something need gating

[ahorek]

@JonRowe I will gladly add a test, but I'm not sure what exactly should be tested...?

this change is just about silencing a deprecation warning in the example app
Rails.application.config.active_record.sqlite3.represent_boolean_as_integer = true
on Rails 6 this file isn't generated, because it's already a default value
on prior Rails versions the file is still generated like before, so the behaviour wasn't actually changed

[JonRowe]

Actually having reviewed the output a bit more closely I'm willing to accept this as is, the failing tests show this polluting the output with a warning and thus this should remove them.

I guess the way to test it in isolation would be to assert no warning output was captured by the generator.