Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve path parsing in _default_render_options #2115

Merged
merged 5 commits into from May 1, 2019

Conversation

jhawthorn
Copy link
Contributor

This improves the path parsing here to be more strict, understand variants, and should support the additional validations around format in Rails 6.0.

I added a few previously failing specs, which this makes pass.

Fixes #2114

cc @samphippen @benoittgt @jaredmoody

@fables-tales
Copy link
Member

@jhawthorn can you take a look at the build failures here? https://travis-ci.org/rspec/rspec-rails/jobs/526608975

@benoittgt
Copy link
Member

It seems #symbols was added in Rails 5 and changed slightly after.

We have also a weird syntax issue. https://travis-ci.org/rspec/rspec-rails/jobs/526609025

SyntaxError:
  /home/travis/build/rspec/rspec-rails/spec/rspec/rails/example/view_example_group_spec.rb:150: syntax error, unexpected ':', expecting tASSOC
  ... :handlers=>['erb'], variants: ['fancy']}, {}, nil])
                                ^
  /home/travis/build/rspec/rspec-rails/spec/rspec/rails/example/view_example_group_spec.rb:150: syntax error, unexpected '}', expecting kEND
  ...>['erb'], variants: ['fancy']}, {}, nil])
                                ^
  /home/travis/build/rspec/rspec-rails/spec/rspec/rails/example/view_example_group_spec.rb:158: syntax error, unexpected kELSE, expecting kEND
  /home/travis/build/rspec/rspec-rails/spec/rspec/rails/example/view_example_group_spec.rb:183: syntax error, unexpected kDO_BLOCK, expecting kEND
  /home/travis/build/rspec/rspec-rails/spec/rspec/rails/example/view_example_group_spec.rb:184: syntax error, unexpected kDO_BLOCK, expecting kEND
  /home/travis/build/rspec/rspec-rails/spec/rspec/rails/example/view_example_group_spec.rb:199: syntax error, unexpected kDO_BLOCK, expecting kEND
  /home/travis/build/rspec/rspec-rails/spec/rspec/rails/example/view_example_group_spec.rb:200: syntax error, unexpected kDO_BLOCK, expecting kEND
  /home/travis/build/rspec/rspec-rails/spec/rspec/rails/example/view_example_group_spec.rb:221: syntax error, unexpected kEND, expecting $end

@fables-tales fables-tales changed the base branch from master to 4-0-dev May 1, 2019 19:10
@fables-tales fables-tales merged commit b4a2682 into rspec:4-0-dev May 1, 2019
benoittgt pushed a commit to benoittgt/rspec-rails that referenced this pull request Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants