allow partial args when using have_enqueued_mail #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this provide parity with have_enqueued_job with partial arguments which would be useful especially in negated case where we want to make sure that absolutely no emails are enqueued
ignatiusreza
force-pushed
the
matchers/all-mail
branch
from
b3da3ee
to
6d3e66b
Compare
|
Hello Thanks a lot for this PR. It looks good to me. |
benoittgt
approved these changes
May 5, 2019
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this provide parity with
have_enqueued_jobwith 0 arguments which would be useful especially in negated case where we want to make sure that absolutely no emails are enqueued