Fix an issue where driven_by(:selenium) is always called #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi, thanks for this, unfortunately If you want to prevent RSpec from calling it again, I'd accept a PR that allows configuring a default driver and using that default value, but I believe this needs to be not lazily loaded. |
JonRowe
previously requested changes
Oct 16, 2019
pirj
reviewed
Oct 16, 2019
Because the before process defined in SystemExampleGroup is executed before the use defined before process, driven_by(:selenium) is always executed. This commit fixes to check the driver configuration at the end of before hooks.
sinsoku
force-pushed
the
fix_duplicate_configuration_for_driver
branch
from
41a607e
to
850f450
Compare
|
Thanks for your reviews. I rewrote the code to check the driver at the end of before hooks. |
|
I also created a pull request (rails/rails#37476) to make |
pirj
reviewed
Oct 17, 2019
JonRowe
approved these changes
Oct 18, 2019
JonRowe
added a commit
that referenced
this pull request
Jan 12, 2020
…_driver Fix an issue where driven_by(:selenium) is always called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the before process defined in SystemExampleGroup is executed
before the use defined before process, driven_by(:selenium) is always
executed.
This commit fixes the driver configuration to be lazy.