Fix Mocha compatibility

[pirj]

RSpec Mocks happened to load its configuration, use the default syntax and define any_instance on Class before Mocha had a chance to in case rspec/rails was required in spec/spec_helper.rb before rspec/core and configuring Mocha as mock_with.

This is not something typical, as usually rails_helper.rb requires rspec-rails, and spec_helper.rb requires rspec-core and configures mock_with, but not something that is a complete no-no.

fixes #2252

• add changelog

[pirj]

@ZeroPointEnergy highly appreciate if you test this fix out with puppet-dashboard.

[benoittgt]

Thanks for the patch. Do you think we can test it in rspec-rails?

Waiting for @ZeroPointEnergy feedback.

[pirj]

Do you think we can test it in rspec-rails?

I'm open to ideas how to do that.

[ZeroPointEnergy]

@pirj is it possible that the PR is not on the 4.x development branch? It threw some dependency errors when I tried to use the branch directly.

However I simply cherry-picked ac886dc on top of v4.0.0.beta3 and can confirm that the patch indeed fixes the issue in puppet-dashboard! 👍

Thanks a lot for your work.

[JonRowe]

Honestly I'm ok with just adding a comment on top explaining why the minimalist approach is taken. To add a test you'd have to assert a bunch of stuff about poisoning the environment which is a fair amount of effort to setup...

[pirj]

Looks green.

[pirj]

Rushed it a bit. @benoittgt do you have any objections on merging as is? I can do a follow-up in that case.

[benoittgt]

No no it's perfect! Thanks a lot 😊

[JonRowe]

Released as v.4.0.0.beta4