Support symbol argument in #on_queue #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Mar 4, 2020
|
Thanks |
|
Changelog in 9ab2690 I messed up the commit message 😂 |
JonRowe
added a commit
that referenced
this pull request
Mar 13, 2020
…ob-matcher Support symbol argument in #on_queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered today that expectations fail when using
#on_queuewith symbol args instead of strings, which surprised me, especially given thatqueue_asin active job classes is usually used with a symbol, too. Not sure if you have any philosophy around this, let me know if I can improve anything.