Generate request specs when scaffold generator is used #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luka Lüdicke <klukasocial+github@gmail.com>
Co-authored-by: Luka Lüdicke <klukasocial+github@gmail.com>
Co-authored-by: Luka Lüdicke <klukasocial+github@gmail.com>
6 tasks
|
Fixes #2230 |
pirj
approved these changes
Mar 13, 2020
|
Changelog entry? |
|
Added after the fact to prevent more builds 😂 |
JonRowe
added a commit
that referenced
this pull request
Mar 13, 2020
Generate request specs when scaffold generator is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some important things to note when generating things, one, your project config will override defaults, even if thats non sensical (e.g. a project can generate controller and request specs here). Two, there are things Rails will generate out of your control.
I took a more minimal approach using rails helpers only and a bit of gsubing to get them to somewhere we'd like, and then had to play whack-a-mole on the tests. Apparently the as scaffolded api views don't work, I guess cause we use sequel lite?
edit still playing whack-a-mole