Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for ActionMailbox #2341

Closed
benoittgt opened this issue May 20, 2020 · 1 comment · Fixed by #2343
Closed

Add documentation for ActionMailbox #2341

benoittgt opened this issue May 20, 2020 · 1 comment · Fixed by #2343

Comments

@benoittgt
Copy link
Member

benoittgt commented May 20, 2020

Hello

While working on rspec/rspec.github.io#143 I noticed that we do not have any documentation for action_mailbox.

PR for action_mailbox on rspec_rails #2119

I looked at a way to add it to our generated app. Is the best way to do it, to use a separate file like for https://github.com/rspec/rspec-rails/blob/master/example_app_generator/generate_action_mailer_specs.rb? (cc @JonRowe)

Any tips to do it properly welcome.

action_mailbox requires active_storage. I wrote a minimal bug report template to use action_mailbox and help me to tackle this issue on rspec-rails

Thanks

@JonRowe
Copy link
Member

JonRowe commented May 21, 2020

Seems like what you have in your bug report is similar to what we'd want in our spec generator? We typically scaffold a thing and make sure the scaffold tests work, so we'd want something similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants