Patch api_request_spec template PATCH/update #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
requested changes
May 25, 2020
There was a problem hiding this comment.
Can you close one or the other PRs? We don't need duplicate PRs as it is easier for us to cherry-pick the merge commit across to the other, my preference is to merge PRs to master and cherry-pick across to 4-0-maintenance but I don't mind which you keep.
Can you fix the spec so the build passes and then I'm happy with this.
| <%= file_name %>.reload | ||
| skip("Add assertions for updated state") | ||
| end | ||
|
|
||
| it "renders a JSON response with the <%= ns_file_name %>" do | ||
| <%= file_name %> = <%= class_name %>.create! valid_attributes | ||
| patch <%= show_helper.tr('@', '') %>, | ||
| params: { <%= singular_table_name %>: invalid_attributes }, headers: valid_headers, as: :json | ||
| params: { <%= singular_table_name %>: new_attributes }, headers: valid_headers, as: :json | ||
| expect(response).to have_http_status(:ok) | ||
| expect(response.content_type).to eq("application/json") |
There was a problem hiding this comment.
Suggested change
| expect(response.content_type).to eq("application/json") | |
| expect(response.content_type).to match(a_string_including("application/json")) |
phanyzewski
force-pushed
the
patch_api_request_generator
branch
from
5326567
to
6b75bc8
Compare
…pdate with valid parameters.
phanyzewski
force-pushed
the
patch_api_request_generator
branch
from
6b75bc8
to
240e860
Compare
|
Thanks! |
JonRowe
added a commit
that referenced
this pull request
May 25, 2020
Patch api_request_spec template PATCH/update
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating api request specs using
rails g scaffoldcreates invalid default test cases for PATCH/update.new_attributes should be used in place of invalid_attributes in the template