Improve enqueued_job at specs and warn about precision. #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
improve-enqueued-job-at
branch
from
2fc5707
to
a815b2e
Compare
benoittgt
approved these changes
May 28, 2020
JonRowe
force-pushed
the
improve-enqueued-job-at
branch
from
a815b2e
to
f9c3bc1
Compare
JonRowe
added a commit
that referenced
this pull request
Jun 10, 2020
JonRowe
added a commit
that referenced
this pull request
Jun 10, 2020
JonRowe
added a commit
that referenced
this pull request
Jun 10, 2020
This was referenced Mar 7, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with our time matching for
enqueued_job, Rails allows microsecond (usec) precision in job queue values, and uses.to_ffor exact time scheduling, which we replicated in #2157, without thisto_fyou cannot check exact time scheduled jobs.However when Rails schedules a job in the future using
wait: nit is doingn.seconds.from_nowwhich does not get passed throughto_f, there is no way for us to detect which is correct so we'll stick with out existing handling, but warn about this precision issue, addingchange(usec: 0)or switching ton.seconds.from_now...Ironically I found this by trying to remove
freeze_timefrom our own specs, it appears thattravel_tospecific time, keepsusecprecision, but notfreeze_time?