Remove old fixture_path support #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
remove-fixture-file-hack
branch
from
64e965b
to
dd09392
Compare
benoittgt
approved these changes
Aug 8, 2020
|
@koenpunt can you try this branch out? |
|
I just wanted to note I tried this out after having issues on Rails edge and confirmed it's happy for me, in tandem with #2385 |
|
Thanks @sudara |
JonRowe
added a commit
that referenced
this pull request
Dec 26, 2020
Remove old fixture_path support
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #2349 which removes the old work around, this seems to no longer apply given our supported levels of Rails.