New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyword arguments in dynamic methods in controller specs #2514
Fix keyword arguments in dynamic methods in controller specs #2514
Conversation
0a7f993
to
0f52603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks cleaner and more isolated.
Subjectively, I would understand the method_missing
if it was defined with a proper way of delegating. Thus, not putting a shade of doubt on its participation in the failure.
583b743
to
756af6e
Compare
756af6e
to
6957188
Compare
…spec-method-missing Fix keyword arguments in dynamic methods in controller specs
Thanks! |
Supersedes #2509 by demonstrating the issue in isolation from the rest of RSpec, many thanks to the original reporter @JoshCheek