Infer the spec type for generator specs #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generator specs are [generated to spec/generator](https://github.com/rspec/rspec-rails/blob/6f8e3ab154a1562919ff1c08b8d19ae5ff6152e9/lib/generators/rspec/generator/generator_generator.rb#L12) Spec-type inferrence (based on file location) is not presently active for generator specs. This adds `:generator ` spec type to the mapping for inference by file location.
|
Thanks, I'm merging this for completeness and its simple, but at some point this functionality will go away as its much more preferred to tag specs manually as its less problematic. |
JonRowe
added a commit
that referenced
this pull request
Apr 24, 2022
Infer the spec type for generator specs
JonRowe
added a commit
that referenced
this pull request
Apr 24, 2022
Infer the spec type for generator specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generator specs are generated to spec/generator
Spec-type inferrence (based on file location) is not presently active for generator specs.
This adds
:generatorspec type to the mapping for inference by file location.