Prefer Pathname#glob
to Dir.[]
at spec/rails_helper.rb template
#2678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Pathname#glob
was added in Ruby 2.5, I thought it would be more concise to use this on spec/rails_helper.rb template.Unlike
Dir.[]
,Pathname#glob
returns an array ofPathname
, butKernel.#require
works the same way if you give anPathname
as an argument, so I think there should be no problem about this difference here. We could add.map(&:to_s)
, but I think that would be a bit redundant.