Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow view specs to use implicit render locals: {...} calls. #2686

Merged
merged 1 commit into from Jun 28, 2023

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Jun 26, 2023

If only locals are provided when rendering a view spec, we can use _default_render_options to provide the view to render, this allows bare render locals: {} style calls.

Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonRowe JonRowe merged commit 5ca2b8e into main Jun 28, 2023
15 checks passed
@JonRowe JonRowe deleted the allow-locals-for-default-render branch June 28, 2023 09:58
JonRowe added a commit that referenced this pull request Jun 28, 2023
@JonRowe
Copy link
Member Author

JonRowe commented Nov 21, 2023

Released in 6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants