Fix failure screenshots on Rails 7.1 #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gap777 The best you can do is to attempt to fix this in a separate PR. |
JonRowe
force-pushed
the
fix-screenshot-meta-access
branch
from
15c9c2d
to
2e776d1
Compare
JonRowe
force-pushed
the
fix-screenshot-meta-access
branch
from
2e776d1
to
e9851b5
Compare
JonRowe
added a commit
that referenced
this pull request
Nov 14, 2023
Fix failure screenshots on Rails 7.1
4 tasks
|
Technically released in 6.0.4 but please use 6.1.0 for Rails 7.1 support. |
|
This was VERY annoying, thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Rails 7.1 they access metadata directly to store the failure screenshot path, we don't allow metadata access like this and it throws an error, this patch makes a dummy metadata available for this purpose, whilst still maintaining our friendly error.
Fixes #2690