Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggest] inputId in input_task_button #1034

Open
jhk0530 opened this issue Mar 30, 2024 · 0 comments
Open

[suggest] inputId in input_task_button #1034

jhk0530 opened this issue Mar 30, 2024 · 0 comments

Comments

@jhk0530
Copy link

jhk0530 commented Mar 30, 2024

Hi, thanks for newly updated feature input_task_button, and I really love it.

I'm not sure this is good or not, but just this is suggestion.

situation

I felt a little awkward during change my previous actionButtons with input_task_button

actionButton of shiny requires inputId, label, icon, width, disabled as parameter

However input_task_button which may replace with actionButton has parameter

id, label, icon, label_busy, icon_busy, type, auto_reset as parameter.

Most of work may done by change actionButton( as input_task_button( but not id.
I understand inputId and id has similar purpose and it seems if i change inputId as id works properly.

suggestion

Actually I don't know the context that specify it as an id rather than an inputId.

but if input_task_button provides inputId as pameter which works as id like below, it also good for shiny users who wants update actionButton as input_task_button like me.

use inputId as default pameter, but also providing id works as now.

example

input_task_button <- function (inputId, id = inputId, label, ...){
...
}

if it seems fine. I 'll try to make PR with this.

Thanks !

Again, thanks for update bslib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant