Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fillable Hidden Tabset Panel #966

Open
TymekDev opened this issue Jan 12, 2024 · 0 comments
Open

Fillable Hidden Tabset Panel #966

TymekDev opened this issue Jan 12, 2024 · 0 comments

Comments

@TymekDev
Copy link

Hi, I am just trying out a fillable layouts and noticed that there is no support for fillability within navset_hidden. I see that it is based on tabsetPanel as opposed to navset_bar that supports fillability and uses an internal function.

I looked at the source code and noticed an unexported makeTabsFillable function. With it I was able to make myself a fillable hidden tabset panel:

fillable_hidden_tabset_panel <- function(..., id) {
  panel <- shiny::tabsetPanel(id = id, type = "hidden", ...)
  panel$children[[2]] <- bslib:::makeTabsFillable(panel$children[[2]])
  bslib::as_fill_carrier(panel)
}

Do you think this is something that {bslib} could support out of the box?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant