Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.popover-body should include only user contents #997

Open
gadenbuie opened this issue Feb 29, 2024 · 0 comments
Open

.popover-body should include only user contents #997

gadenbuie opened this issue Feb 29, 2024 · 0 comments

Comments

@gadenbuie
Copy link
Member

In the current configuration, we add the <button> element inside the .popover-body > div container.

<div class="popover-body">
	<div style="display:contents;">
		<!-- user content here -->
		<button type="button" aria-label="Close" class="btn-close" style="position:absolute; top:0.6rem; right:0.25rem; width:0.55rem; height:0.55rem; background-size:0.55rem;"></button>
	</div>
</div>

It'd be helpful to keep the .popover-body to just having user-supplied content. The close button could be a sibling of .popover-body without changing appearance or (probably) behavior. The goal is that users should be able to write rules like .popover-body > div > :last-child to target the final (or first) content element in the popover.

In particular, I wanted to do something like

.popover-body > div > :last-child {
  margin-bottom: 0
}
@gadenbuie gadenbuie added this to the v1.7.0 milestone Mar 11, 2024
@cpsievert cpsievert removed this from the v0.7.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants