Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ace to get latest a11y fixes #13592

Closed
4 tasks done
gtritchie opened this issue Sep 5, 2023 · 1 comment
Closed
4 tasks done

Update Ace to get latest a11y fixes #13592

gtritchie opened this issue Sep 5, 2023 · 1 comment

Comments

@gtritchie
Copy link
Member

gtritchie commented Sep 5, 2023

System details

RStudio Edition : Desktop and Server
RStudio Version : 2023.09.0-daily+397
OS Version      : any
R Version       : any

RStudio 2023.09 was upgraded to Ace 1.19; there have been several a11y improvements made to Ace since then, and we should consider upgrading Ace again soon to pick these up. From https://github.com/ajaxorg/ace/releases:

v1.20.0

Add gutter controls to keyboard accessibility mode (#5146) (5f2face)
Hide Ace content from assistive technologies to improve a11y by @akoreman in #5160

v1.23.0

signal gutterkeydown in keyboard accessibility mode (#5202) (538b18c)
Improve ARIA labelling fold controls (#5205) (dad5e6f)

v1.23.2

bug(autocomplete): fix a11y violations by @oykuyilmaz in #5241

v1.24.0

Allow more lines in hidden textarea to improve screen reader experience on Windows (#5225) (bccff5a)

  • I have read the guide for submitting good bug reports.
  • I have installed the latest version of RStudio, and confirmed that the issue still persists.
  • If I am reporting an RStudio crash, I have included a diagnostics report.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
@gtritchie gtritchie added bug ace accessibility new New incoming issues, ready for initial review. labels Sep 5, 2023
@kevinushey kevinushey added this to the Ocean Storm milestone Sep 5, 2023
@ronblum ronblum removed the new New incoming issues, ready for initial review. label Sep 6, 2023
@jgutman jgutman self-assigned this Sep 28, 2023
@jonvanausdeln jonvanausdeln self-assigned this Nov 1, 2023
@jonvanausdeln
Copy link

Verified on 2023.12.0-daily+237
Windows 11, MacOS 12.6

All related desktop automation passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants