Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui.Rmd support #466

Open
jcheng5 opened this issue Dec 3, 2020 · 2 comments · May be fixed by #467
Open

ui.Rmd support #466

jcheng5 opened this issue Dec 3, 2020 · 2 comments · May be fixed by #467
Milestone
v1.5.16

Comments

@jcheng5
Copy link
Member

jcheng5 commented Dec 3, 2020

(Maybe this already works?)
rstudio/rmarkdown#1926
@jcheng5 jcheng5 added this to the v1.15.16 milestone Dec 3, 2020
@aronatkins
Copy link
Contributor

The logic here will need adjusting:

shiny-server/lib/router/router.js

Lines 229 to 257 in 191c32c

var app = _.find(files, function(entry) {
return /^server\.r$/i.test(entry);
});
var singleApp = _.find(files, function(entry) {
return /^app\.r$/i.test(entry);
});
var rmd = _.find(files, function(entry) {
return /\.rmd$/i.test(entry);
});
var indexRmd = _.find(files, function(entry) {
if (/^index\.rmd$/i.test(entry)){
return entry;
}
return false;
});
var indexHtm = _.find(files, function(entry) {
if (/index\.htm(l)?$/i.test(entry)){
return entry;
}
return false;
});
var indexType = indexRmd ? 'rmd' : indexHtm ? 'html' : null;
var indexPath = indexRmd || indexHtm;
if (app || singleApp){
appSpec.settings.mode = 'shiny';
} else if(rmd){

Having server.R no longer indicates a Shiny application by itself. Here is how we perform the detection in rsconnect: rstudio/rsconnect#461

The R/SockJSAdapter.R uses rmarkdown::run if SHINY_MODE is rmd. That is enough (with new rmarkdown install).

@jcheng5
Copy link
Member Author

jcheng5 commented Dec 8, 2020

Thanks @aronatkins!

jcheng5 added a commit that referenced this issue Dec 9, 2020
@jcheng5
Support ui.Rmd
0d3535c 
Fixes #466
@jcheng5 jcheng5 linked a pull request Dec 9, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.16
Development

Successfully merging a pull request may close this issue.

Support ui.Rmd rstudio/shiny-server
2 participants
@jcheng5 @aronatkins