Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ionRangeSlider to use CSS variables in a Bootstrap 5 context #3991

Open
gadenbuie opened this issue Mar 8, 2024 · 0 comments
Open
Assignees
Milestone

Comments

@gadenbuie
Copy link
Member

ionRangeSlider's sass still uses color functions that result in realized colors -- as opposed to CSS variables -- once compiled.

$bg: $body-bg !default;
$fg: color-contrast($body-bg) !default;
$accent: #428bca !default;
// "Low-level" coloring, borders, and fonts
$line_bg: linear-gradient(to bottom, mix($bg, $fg, 87%) -50%, $bg 150%) !default;
$line_bg_color: mix($bg, $fg, 93%) !default;
$line_border: 1px solid mix($bg, $fg, 80%) !default;

We should either:

  1. Update ionRangeSlider/scss/shiny.scss to avoid these color calculations.
  2. Add ionRangeSlider/scss/bootstrap5.scss to avoid these color calculations in BS5, renaming the current shiny.scss to bootstrap4.scss.
@gadenbuie gadenbuie self-assigned this Mar 8, 2024
@gadenbuie gadenbuie added this to the 1.9 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant