Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Feature Importance of models #16

Open
ElianoMarques opened this issue Apr 29, 2019 · 3 comments
Open

feature request: Feature Importance of models #16

ElianoMarques opened this issue Apr 29, 2019 · 3 comments

Comments

@ElianoMarques
Copy link

would it be possible to link features importance into the package?

@yutannihilation
Copy link
Contributor

This probably requires to update xgboost4j-spark to at least 0.82 to use Booster.getScore():

dmlc/xgboost@431c850

sparkxgb currently uses 0.81:

packages = "ml.dmlc:xgboost4j-spark:0.81"

(I tried to make a PR for this, but couldn't find how to use sparklyr::compile_package_jars() with a dependency jar...)

@javierluraschi
Copy link
Contributor

I would try to bump the version in dependencies.R to the newer version, that's about it. To recompile the jars you need to run https://github.com/rstudio/sparkxgb/blob/master/configure.R but I don't think that's required since the Scala code is not changed. Would be great if you could send a PR cause that way we can see what breaks in the tests and help out a bit as well.

@yutannihilation
Copy link
Contributor

Thanks!

I don't think that's required since the Scala code is not changed.

But, doesn't inst/java/sparkxgb-*.jar contain all the things including the dependency? If so, changing the dependency should require rebuild. Sorry, I don't know well about Java ecosystem and the structure of a JAR....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants