Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SendPhoto]: 400 Bad request (chat_id not found) #1321

Open
bekzod-murotboyev opened this issue Feb 12, 2024 · 5 comments
Open

[SendPhoto]: 400 Bad request (chat_id not found) #1321

bekzod-murotboyev opened this issue Feb 12, 2024 · 5 comments
Labels

Comments

@bekzod-murotboyev
Copy link

Describe the bug
org.telegram.telegrambots.meta.api.methods.send.SendPhoto class fields are not annotated with @JsonProperty annotation, that is why always telegram bot api returns 400 Bad request with content of "chat_id" not found!

To Reproduce
Steps to reproduce the behavior:

  1. Go to org.telegram.telegrambots.meta.api.methods.send.SendPhoto
  2. Annotate chatId and other fields with @JsonProperty annotation
@Georglider
Copy link

I have made a pull request regarding to this issue: #1302

@TheQuiu
Copy link

TheQuiu commented Mar 13, 2024

🎂👏💋

@bekzod-murotboyev
Copy link
Author

Thanks for your attention. From which version those changes will be available?

@Georglider
Copy link

Thanks for your attention. From which version those changes will be available?

I don't know, owner of this repo should accept #1302 in order for changes to apply.

@rubenlagus
Copy link
Owner

I'll check it now that the new version is fully out. Need to consider this change carefully since this was intentionally done as it is now (since the proposed solution is only partial support for the Bots API. hence, would require some extra documentation/Javadocs to ensure it is clear for everything.

Also, the proposed MR doesn't include any kind of UT that proves it works as it is expected

@Chase22 Chase22 added the bug label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants