Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Capybara/RSpec department #47

Open
ydah opened this issue Apr 24, 2023 · 1 comment
Open

Proposal for Capybara/RSpec department #47

ydah opened this issue Apr 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ydah
Copy link
Member

ydah commented Apr 24, 2023

The Capybara/SpecificMatcher, Capybara/NegationMatcher, and Capybara/VisibilityMatcher cops depend on methods from the Capybara::RSpecMatchers class.

https://www.rubydoc.info/gems/capybara/Capybara/RSpecMatchers

While these cops were previously implemented in the RuboCop RSpec gem and did not cause any issues, they may not be appropriate for RuboCop Capybara, which is not limited to RSpec extensions.
Therefore, it might be a good to create a separate Capybara/RSpec department to handle these RSpec-specific extensions.

@ydah ydah changed the title Proposal for Capybara/RSpec department Proposal for Capybara/RSpec department Apr 24, 2023
@ydah
Copy link
Member Author

ydah commented Apr 24, 2023

It might be a good to implement cops related to Capybara::Minitest::Assertions and Capybara::Minitest::Expectation as Capybara/Minitest department cops in a similar way to the proposed Capybara/RSpec department.

@ydah ydah added the enhancement New feature or request label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant