Remove Capybara/ClickLinkOrButtonStyle cop
#81
Comments
|
Hey @ydah, on the current latest release of Even though you are planning to delete this cop, I think you should at least create a new release with the up to date default - this discrepancy between the cop and the documentation can be a pain to rationalise 😢 |
|
@ydah I would prefer that we keep this cop; but perhaps have it turned off by default? My team loves that we can rely on it to help us make good accessibility decisions when writing end-to-end tests. Of course, it's also possible that having this in the linter is "too much" and people who like it can make a |
|
@zspencer I think proceeding in the direction of deleting |
|
@ydah This is great! I love it! |
This rule's default enforce style, `link_or_button` [1], introduced a number of problems [2]. Specifically, I noticed issues switching to `click_on` from `click_button` [3]. The hack solution is to ignore or disable the rule in some places but not in others. Not great. As a result, the rule is slated for removal [4] and replacement [5] by a new rule. In the interim, configuring this rule to enforce a strict use of `click_button` and `click_link` is preferential (and, honestly, more communicative). In this author's opinion, user interface specs should be explicit about the markup under test. [1] https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle [2] rubocop/rubocop-capybara#61 [3] rubocop/rubocop-capybara#61 (comment) [4] rubocop/rubocop-capybara#81 [5] rubocop/rubocop-capybara#99
## Description This rule's default enforce style, `link_or_button` [1], introduced a number of problems [2]. Specifically, I noticed issues switching to `click_on` from `click_button` [3]. The hack solution is to ignore or disable the rule in some places but not in others. Not great. As a result, the rule is slated for removal [4] and replacement [5] by a new rule. In the interim, configuring this rule to enforce a strict use of `click_button` and `click_link` is preferential (and, honestly, more communicative). In this author's opinion, user interface specs should be explicit about the markup under test. [1] https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle [2] rubocop/rubocop-capybara#61 [3] rubocop/rubocop-capybara#61 (comment) [4] rubocop/rubocop-capybara#81 [5] rubocop/rubocop-capybara#99 ## Commits - Configure `Capybara/ClickLinkOrButtonStyle` - Bump version to v1.1.0
#61 (comment)
The text was updated successfully, but these errors were encountered: