Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"supported protobuf version" in README seems outdated #345

Open
doudou opened this issue Feb 2, 2017 · 3 comments
Open

"supported protobuf version" in README seems outdated #345

doudou opened this issue Feb 2, 2017 · 3 comments

Comments

@doudou
Copy link

doudou commented Feb 2, 2017

master's README claims 2.5, while the travis tests run with PROTOBUF_VERSION=2.6.1 and the specs include the google unit tests files that have oneof (a 2.6+ feature).

@henriklb
Copy link

henriklb commented Jul 6, 2018

To add to that,

In order to compile I had to specify the plugin, this was not intuitive for a noob like me. Maybe update the README to inform of this?
protoc --plugin=protoc-gen-ruby-protobuf=/var/lib/gems/2.3.0/gems/protobuf-3.8.4/bin/protoc-gen-ruby -I . --ruby-protobuf_out . test.proto

@zachd
Copy link

zachd commented Nov 27, 2018

Same here, it looks like Google have added support for --ruby_out in protoc which generates their own code using the google-protobuf gem. This project now requires a specific plugin flag to be set in the protoc compiler command.

@dsimmsatsquare
Copy link

Aside for anyone else who gets excited about support from Google for ruby: that only supports version 3 (unlike ruby-protobuf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants