Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Args -> ArgumentsNode #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidwessman
Copy link

I tried to address #351 since it seemd limited in scope, so hopefully:

I was not sure if the s(:args, children, location) in lib/syntax_tree/translation/parser.rb should be updated as well (tried it but it broke the tests).
And the replacement of parts -> arguments was trial-and-error in a lot of places, since it was hard to know the types of
node.contens.arguments.arguments.arguments or something similar.

Please let me know if I should change anything, or feel free to reject the changes :)

- Fixes ruby-syntax-tree#351
- Changed all use of `parts` to `arguments` as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Args -> ArgumentsNode
1 participant