Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscript assignment should not be split into multiple lines #407

Open
maxnotarangelo opened this issue Aug 31, 2023 · 0 comments
Open

subscript assignment should not be split into multiple lines #407

maxnotarangelo opened this issue Aug 31, 2023 · 0 comments

Comments

@maxnotarangelo
Copy link

When you assign a value to an element of an array or a hash, it looks pretty weird if the assignment part is split into three lines instead of one.

Original:

some_hash = { name: "my hash" }
some_array = ["hello", "goodbye"]

if some_condition?
  some_hash[:description] = "a long description that will be too long for a single line"
  some_array[0] = "a very long greeting that will be much too long for a single line"
end

Formatted:

some_hash = { name: "my hash" }
some_array = %w[hello goodbye]

if some_condition?
  some_hash[
    :description
  ] = "a long description that will be too long for a single line"
  some_array[
    0
  ] = "a very long greeting that will be much too long for a single line"
end

Preferred formatting:

some_hash = { name: "my hash" }
some_array = %w[hello goodbye]

if some_condition?
  some_hash[:description] =
    "a long description that will be too long for a single line"
  some_array[0] =
    "a very long greeting that will be much too long for a single line"
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant