Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: "historical binary regexp match /.../n against UTF-8 string" #219

Open
nevans opened this issue Nov 6, 2023 · 0 comments
Open

Comments

@nevans
Copy link
Collaborator

nevans commented Nov 6, 2023

Seeing the following in logs:

warning: historical binary regexp match /.../n against UTF-8 string

This is triggered when UTF-8 strings that are not ascii_safe? are checked with the /[\r\n]/n regexp in send_string_data(str, tag) (command_data.rb:57).

Other than adding noise to the logs, I don't know if it makes any significant difference. If we were looking at MatchData, it would matter... but here we're just looking at match?.

See also: https://bugs.ruby-lang.org/issues/19767 and the commit links in the comments there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant