Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation specific build_exception #521

Open
bjfish opened this issue Sep 24, 2021 · 0 comments
Open

Implementation specific build_exception #521

bjfish opened this issue Sep 24, 2021 · 0 comments

Comments

@bjfish
Copy link
Contributor

bjfish commented Sep 24, 2021

The current build_exception relies on the Exception implementation containing a instance variable mesg:
https://github.com/ruby/ruby/blob/c8661de0143c1d434dd9f68910ae304c59f8576b/ext/psych/psych_to_ruby.c#L9-L16

Should this use rb_exc_new_str() (which would also call initialize)?

cc: @eregon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjfish