Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stringio should be a stdlib, but it's in core/ #1549

Open
pocke opened this issue Sep 27, 2023 · 0 comments
Open

stringio should be a stdlib, but it's in core/ #1549

pocke opened this issue Sep 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pocke
Copy link
Member

pocke commented Sep 27, 2023

In Ruby, stringio is a stdlib.
https://github.com/ruby/ruby/tree/50520cc1930331bccdb94730e17ddc01798f2be0/ext/stringio

But currently, RBS has string_io as a core library unexpectedly.
https://github.com/ruby/rbs/blob/abcc97d3c8b024856ba9603a7ef22d422652ff42/core/string_io.rbs

So we should do the two things:

  • Move string_io.rbs from core/ to stdlib/.
  • Rename it to stringio.rbs
    • because the library name is stringio.

BTW, this will introduce a breaking change. We should do it carefully. For example, we can provide a migration process.
@pocke pocke added the bug Something isn't working label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pocke