Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 16 is deprecated on GitHub, use Node 20 #539

Closed
2 tasks done
TWiStErRob opened this issue Oct 25, 2023 · 7 comments · Fixed by #540
Closed
2 tasks done

Node 16 is deprecated on GitHub, use Node 20 #539

TWiStErRob opened this issue Oct 25, 2023 · 7 comments · Fixed by #540

Comments

@TWiStErRob
Copy link
Contributor

Ensure the following before filing this issue

  • I verified it reproduces with the latest version with - uses: ruby/setup-ruby@v1 (see Versioning policy)

  • I tried to reproduce the issue locally by following the workflow steps (including all commands done by ruby/setup-ruby, except for Downloading Ruby & Extracting Ruby),
    and it did not reproduce locally (if it does reproduce locally, it's not a ruby/setup-ruby issue)

Are you running on a GitHub-hosted runner or a self-hosted runner?

GitHub-hosted runner

Link to the failed workflow job (must be a public workflow job, so the necessary information is available)

N/A, it was triggered on private, couldn't repro on public, it seems not all runners have the deprecation yet.

Any other notes?

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, ruby/setup-ruby@v1, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

image

@eregon
Copy link
Member

eregon commented Oct 25, 2023

Could you make a PR? You just need to change https://github.com/ruby/setup-ruby/blob/master/action.yml

@TWiStErRob
Copy link
Contributor Author

TWiStErRob commented Oct 25, 2023

@eregon #540, other actions increased their major version for this change.
e.g. https://github.com/actions/checkout/releases/tag/v4.0.0

@TWiStErRob
Copy link
Contributor Author

TWiStErRob commented Oct 25, 2023

Note: the warning won't show for now: actions/upload-artifact#444 (comment), but a released version should be ready for when they bring it back.

@eregon
Copy link
Member

eregon commented Oct 26, 2023

@eregon #540, other actions increased their major version for this change. e.g. https://github.com/actions/checkout/releases/tag/v4.0.0

Yeah I know. IMO that's unnecessary work, it's making everyone change things when nothing needs to change in their workflow actually, at least as long as they are running on GitHub-hosted runners. And if not, then node20 should be installed on self-hosted runners. So anyway, nothing meaningful to change for workflows, so a waste of a major version.

@srallen
Copy link

srallen commented Feb 16, 2024

👋 I'm still seeing warnings about upgrading to Node 20:

Screenshot 2024-02-16 at 5 10 57 PM

I believe this is due to this action's use of actions/cache@v3:

"@actions/cache": "^3",
Version 4 for actions/cache doesn't appear to actually have breaking changes. Would it be possible for this action to bump to v4 of actions/cache?

@TWiStErRob
Copy link
Contributor Author

That's a node package, embedded into dist. I don't think GHA can see that.

Are you sure there's no actions/cache@v3 in your workflow or one of the composite actions?

@srallen
Copy link

srallen commented Feb 20, 2024

@TWiStErRob I found v3 of action/cache in another 3rd party composite action that I missed the first time through trying to find the source of the warning I was seeing. Thanks for taking the time to respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants