Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare to release RubyGems 3.3.27 and Bundler 2.3.27 #6717

Merged
merged 13 commits into from
Nov 1, 2023
Merged

Prepare to release RubyGems 3.3.27 and Bundler 2.3.27 #6717

merged 13 commits into from
Nov 1, 2023

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jun 1, 2023

@jackorp @hsbt
Provide fix for bundler Gemfile resolving regression.
d084df4 
Instead of resolving to correct Ruby platform, it preferred the
archful package, that is actually incompatible.

See sclorg/s2i-ruby-container#469
for an example of the bug.

Commit taken from:
<#6225>
and adapted:
<7b64c64>
for the PR#6225.
@jackorp @hsbt
Tests from bundler's PR#6225.
b72063e 
See <#6225>.
@deivid-rodriguez
Copy link
Member

Thanks both for this, it seems that the backports need some work for old Ruby support?

@jackorp @hsbt
Backport "Fix another issue of Bundler not falling back to an install…
a096e49 
…able candidate"

In this case, when materializing a legacy lockfile using only "ruby"
platform, and in frozen mode.

=====

Commit adapted from: #6261
Specific PR's commit hash: 93af31a
@jackorp
Copy link
Contributor

jackorp commented Jun 12, 2023

it seems that the backports need some work for old Ruby support?

Looking at Ruby 2.4, the message when it fails

/home/runner/work/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.13/lib/bundler/rubygems_ext.rb:352:in `glob': no implicit conversion of Hash into Integer (TypeError)

Seems to point me towards the difference between bundler 2.4.13 and the v2.3.27 (this PR's) one.

The old Rubies were dropped from workflows in 77e7b79

And the same commit caused the error above. See 77e7b79#diff-dd13cb568c0fc396fbad7bc3665465e0fc81ce91042afc2d0d537d08a31c649e

In short, I don't think we can expect that upgrade tests using the latest versions of Bundler and Rubygems will work moving forward.

@hsbt hsbt force-pushed the prepare-rg-3-3-27-bundler-2-3-27 branch 2 times, most recently from 19d3d44 to 1bc8600 Compare June 12, 2023 09:46
@hsbt hsbt self-assigned this Jun 29, 2023
@hsbt
Copy link
Member Author

hsbt commented Oct 30, 2023

@jackorp I'm considering to release RubyGems-3.3.27 and Bundler-2.3.27 from this PR. Can you confirm to resolve your issue from this branch? Thanks.

@hsbt hsbt force-pushed the prepare-rg-3-3-27-bundler-2-3-27 branch 2 times, most recently from 99bca2e to e7a2956 Compare October 30, 2023 06:22
@jackorp
Copy link
Contributor

jackorp commented Oct 30, 2023

I confirm that the issue is no longer present with this branch, thanks.

@hsbt hsbt force-pushed the prepare-rg-3-3-27-bundler-2-3-27 branch 2 times, most recently from 666d313 to cabe9c6 Compare October 30, 2023 10:14
@hsbt hsbt force-pushed the prepare-rg-3-3-27-bundler-2-3-27 branch from cabe9c6 to 2ad99fa Compare October 30, 2023 11:30
@hsbt hsbt merged commit a7194d7 into 3.3 Nov 1, 2023
67 checks passed
@hsbt hsbt deleted the prepare-rg-3-3-27-bundler-2-3-27 branch November 1, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hsbt hsbt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsbt @deivid-rodriguez @jackorp